Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lifecycle-operator): remove spans for reconciliation loops, adjust log levels #2310

Merged
merged 8 commits into from
Oct 25, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Oct 23, 2023

Part of #2290

…ng levels

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit eac2d9b
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/653604eee79572000892ef64
😎 Deploy Preview https://deploy-preview-2310--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2310 (3ade84e) into main (c6d9c52) will decrease coverage by 0.14%.
Report is 14 commits behind head on main.
The diff coverage is 64.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   85.68%   85.54%   -0.14%     
==========================================
  Files         161      161              
  Lines       10246    10190      -56     
==========================================
- Hits         8779     8717      -62     
- Misses       1192     1196       +4     
- Partials      275      277       +2     
Files Coverage Δ
...e-operator/controllers/common/evaluationhandler.go 76.51% <100.00%> (ø)
...cle-operator/controllers/common/helperfunctions.go 98.63% <100.00%> (ø)
...ecycle-operator/controllers/common/phasehandler.go 80.64% <100.00%> (-0.31%) ⬇️
...rator/controllers/lifecycle/keptnapp/controller.go 62.13% <ø> (-1.35%) ⬇️
...ontrollers/lifecycle/keptnappversion/controller.go 81.96% <100.00%> (-0.35%) ⬇️
...ator/controllers/lifecycle/keptntask/controller.go 50.84% <ø> (-5.50%) ⬇️
.../controllers/lifecycle/keptnworkload/controller.go 69.04% <ø> (-1.66%) ⬇️
...llers/lifecycle/keptnworkloadversion/controller.go 79.14% <94.11%> (+1.31%) ⬆️
...ontrollers/lifecycle/keptnevaluation/controller.go 76.08% <63.63%> (-0.05%) ⬇️
...fecycle-operator/controllers/common/taskhandler.go 74.82% <56.25%> (-4.13%) ⬇️
... and 1 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.49% <54.71%> (-1.15%) ⬇️
lifecycle-operator 85.65% <51.35%> (+0.18%) ⬆️
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl marked this pull request as ready for review October 24, 2023 10:51
@bacherfl bacherfl requested a review from a team as a code owner October 24, 2023 10:51
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanky!

@bacherfl bacherfl merged commit d73008c into keptn:main Oct 25, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants