Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lifecycle-operator): remove spans created by webhook #2331

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

bacherfl
Copy link
Member

Part of #2290

This PR removes the spans created by the webhook, as they did not prove to be useful

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 0fab211
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6538f4e6e340ef0008451312
😎 Deploy Preview https://deploy-preview-2331--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2331 (0fab211) into main (d73008c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
- Coverage   85.54%   85.49%   -0.06%     
==========================================
  Files         161      161              
  Lines       10190    10166      -24     
==========================================
- Hits         8717     8691      -26     
- Misses       1196     1197       +1     
- Partials      277      278       +1     
Files Coverage Δ
...pod_mutator/handlers/appcreationrequest_handler.go 100.00% <100.00%> (ø)
...operator/webhooks/pod_mutator/handlers/workload.go 98.63% <100.00%> (-0.12%) ⬇️
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 96.05% <100.00%> (+0.75%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 58.13% <ø> (+0.63%) ⬆️
lifecycle-operator 85.61% <100.00%> (-0.04%) ⬇️
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review October 25, 2023 11:19
@bacherfl bacherfl requested a review from a team as a code owner October 25, 2023 11:19
@bacherfl bacherfl merged commit 9f21fb6 into keptn:main Oct 25, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants