Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adapt landing page with better fitting titles and links #2336

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Oct 25, 2023

This PR

Notes for reviewers:

Please check that the links on the landing page lead to pages that make sense for you.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit cc75714
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/653fc27691e0110008f57a3b
😎 Deploy Preview https://deploy-preview-2336--keptn-lifecycle-toolkit.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review October 25, 2023 13:04
@mowies mowies requested review from a team as code owners October 25, 2023 13:04
odubajDT
odubajDT previously approved these changes Oct 25, 2023
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pare down some rubbish from this page. I would delete the almost year-old video and all the text that follows it. So we just have the three ugly little icons, each of which links to the appropriate sub-section of https://main.lifecycle.keptn.sh/docs/intro/ , which has brief but intelligent descriptions of the three components or use-cases or features or whatever we are calling them.

Then each of those subsections links to the relevant Getting Started exercise and guide chapter.

docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Show resolved Hide resolved
docs/content/en/_index.md Outdated Show resolved Hide resolved
docs/content/en/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement so I'm approving it. I still think that the syntactical/grammatical mess in the second section about the use-cases/features should be fixed sooner rather than later, that the video should be removed, and that we should use the same names for use-cases/components/features on the landing page as we use in the docs but we can fix that later.

@mowies mowies merged commit a56d6e0 into keptn:main Oct 31, 2023
18 checks passed
@mowies mowies deleted the landing-page-adaptations branch October 31, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt Keptn landing page
3 participants