Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use debug stages in local docker build make commands #234

Merged
merged 4 commits into from
Nov 2, 2022
Merged

feat: Use debug stages in local docker build make commands #234

merged 4 commits into from
Nov 2, 2022

Conversation

mowies
Copy link
Member

@mowies mowies commented Oct 25, 2022 •
edited
Loading

This PR

  • changes the makefiles to build the corresponding debug stages for scheduler and operator. The debug stages use the distroless debug-nonroot image tag which comes with a shell

@mowies
ci: Pipeline enhancements
0c88aa1 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
ci: Make use of debug stages in local docker build make commands
c9d6ec6 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

fix yaml syntax

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

fix quotes

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

execute conditional once and use as variable later on

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

replace keptn-sandbox with keptn

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

fix yaml syntax in docker build step

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>

enable image pushes again

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
fix docker cmds
45c0341 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies
revert change
07cf789 
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@mowies mowies marked this pull request as ready for review November 2, 2022 14:26
thschue
thschue approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue added this to the 0.4.x milestone Nov 2, 2022
philipp-hinteregger
philipp-hinteregger approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@philipp-hinteregger philipp-hinteregger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mowies mowies changed the title ci: Make use of debug stages in local docker build make commands feat: Use debug stages in local docker build make commands Nov 2, 2022
@mowies mowies merged commit 6423834 into keptn:main Nov 2, 2022
@mowies mowies deleted the use-debug-stages branch November 2, 2022 15:01
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

@philipp-hinteregger philipp-hinteregger philipp-hinteregger approved these changes

@thisthat thisthat Awaiting requested review from thisthat

@bacherfl bacherfl Awaiting requested review from bacherfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mowies @thschue @philipp-hinteregger