deps(metrics-operator): replace grpc version with v1.58.3 #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
+ Coverage 85.53% 85.55% +0.02%
==========================================
Files 161 161
Lines 10166 10166
==========================================
+ Hits 8695 8698 +3
+ Misses 1194 1192 -2
+ Partials 277 276 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
approved these changes
Oct 30, 2023
|
Let's run the security scan after the build is completed to be sure that the issue is fixed (I bet it will :) ) |
odubajDT
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2350
The affected library (
google.golang.org/grpc) that caused the security check to fail is a transitive dependency that is introduced viak8s.io/apiserver. Since the dependency togoogle.golang.org/grpchas not been updated to the version in which the vuln is fixed yet, this PR adds the replace in thego.modfile.