fix: helm charts image registry, image pull policy and install action #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
+ Coverage 85.46% 85.49% +0.02%
==========================================
Files 161 161
Lines 10166 10166
==========================================
+ Hits 8688 8691 +3
+ Misses 1199 1197 -2
+ Partials 279 278 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
github-actions
bot
added
the
documentation
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
RealAnna
force-pushed
the
fix/add_registry_values
branch
from
3f620a0
to
a26a832
Compare
Signed-off-by: realanna <anna.reale@dynatrace.com>
mowies
reviewed
Oct 30, 2023
Signed-off-by: realanna <anna.reale@dynatrace.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> Signed-off-by: RealAnna <89971034+RealAnna@users.noreply.github.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
Signed-off-by: realanna <anna.reale@dynatrace.com>
odubajDT
reviewed
Oct 30, 2023
RealAnna
changed the title
Signed-off-by: realanna <anna.reale@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
reviewed
Oct 30, 2023
bacherfl
approved these changes
Oct 30, 2023
odubajDT
reviewed
Oct 30, 2023
odubajDT
reviewed
Oct 30, 2023
odubajDT
approved these changes
Oct 30, 2023
This was referenced Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2360
also adds missing image function and imagePullPolicy from the metrics operator templates
to check that it works I added tests in the helm test folder and used a value file for our install action