Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler): ignore OTel security issue in scheduler #2364

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Oct 30, 2023

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 64dedf4
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/653fa7095c2aeb0008ae4891
😎 Deploy Preview https://deploy-preview-2364--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the ops label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2364 (3802aba) into main (a9da96a) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head 3802aba differs from pull request most recent head 281e1c5. Consider uploading reports for the commit 281e1c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
+ Coverage   85.46%   85.52%   +0.05%     
==========================================
  Files         161      161              
  Lines       10166    10166              
==========================================
+ Hits         8688     8694       +6     
+ Misses       1199     1195       -4     
+ Partials      279      277       -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.49% <ø> (+0.42%) ⬆️
lifecycle-operator 85.61% <ø> (ø)
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT marked this pull request as ready for review October 30, 2023 13:22
@odubajDT odubajDT requested a review from a team as a code owner October 30, 2023 13:22
.trivyignore Outdated Show resolved Hide resolved
RealAnna
RealAnna previously approved these changes Oct 30, 2023
.trivyignore Outdated Show resolved Hide resolved
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odubajDT odubajDT merged commit a10594f into main Oct 30, 2023
36 checks passed
@odubajDT odubajDT deleted the fix/security-issue branch October 30, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants