Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use Volumes with KeptnTaskDefinition #3519

Open
StackScribe opened this issue May 15, 2024 · 0 comments
Open

Document how to use Volumes with KeptnTaskDefinition #3519

StackScribe opened this issue May 15, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation status: todo

Comments

@StackScribe
Copy link
Contributor

StackScribe commented May 15, 2024

Summary

Need to document how to Volumes with a KeptnTaskDefinition

Technical details

This comes from a Slack discussion: https://cloud-native.slack.com/archives/C017GAX90GM/p1715626404854909

@RealAnna replies: "KeptnTaskDefinition can refer to a containerSpec so basically you can define a container to run as in the K8s core API so you can mount volumes into the container's filesystem like you would do for a Pod container. When converting the definition to a job, Keptn will instantiate an empty dir volume if you filled the respective VolumeMount spec. Here is the corresponding code.

containerSpec is documented in the API reference but is not in the CRD reference for either KeptnTaskDefinition or KeptnAppContext, which is what the API documentation says actually references it.

This is a complex enough subject that it warrants a section in the Deployment tasks guide. This should include this additional Anna quote: "the volumes should be specified at pod spec level there is no definition in k8s api at container level." and additional background as well as an annotated example or two.

Anna does note that, to do what the user is requesting requires modifying the container-runtime code and the user is to file a ticket for that. That exercise could affect this issue, but it seems that we should document the use case that we already support since that was the original vision of the implementation as well as documenting the modified implementation.

Interim DoD

  • Add caveat/note about the current limit of support for mounted volumes with Keptn
  • When ticket is filed to fix this, link to that ticket
  • Be sure that the note includes the "Volume" string and anything else for which a user might search

DoD

  • Update the KeptnTaskDefinition, KeptnContext, or other CRD reference pages with the parameters required to support Volumes
  • Add "How to provide Volumes" section to "Deployment tasks" guide. Include background information and annotated examples for supported use cases
  • Add links to the guide section from appropriate CRD reference pages
@StackScribe StackScribe added documentation Improvements or additions to documentation status: ready-for-refinement Issue is relevant for the next backlog refinment labels May 15, 2024
@odubajDT odubajDT added status: todo and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status: todo
Projects
None yet
Development

No branches or pull requests

2 participants