Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Analysis documentation, to explain how to get failure #3542

Open
3 tasks
RealAnna opened this issue Jun 3, 2024 · 0 comments
Open
3 tasks

Improve Analysis documentation, to explain how to get failure #3542

RealAnna opened this issue Jun 3, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation metrics-operator

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Jun 3, 2024

If an objective like the following fails, the overall status will not reflect that since the objective is not a key objective

objectives:
  - analysisValueTemplateRef:
      name: request-duration
    keyObjective: false
    target:
      failure:
        greaterThan:
          fixedValue: 3
      warning:
        greaterThan:
          fixedValue: 2
    weight: 1
  totalScore:
    passPercentage: 90
    warningPercentage: 75

However the status is neither explicitly set to pass so it is omitted...

DoD

@RealAnna RealAnna added bug Something isn't working documentation Improvements or additions to documentation metrics-operator status: needs-discussion labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation metrics-operator
Projects
None yet
Development

No branches or pull requests

1 participant