Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return error details from dynatrace metric provider in analysis #3545

Open
2 tasks
RealAnna opened this issue Jun 4, 2024 · 0 comments
Open
2 tasks

return error details from dynatrace metric provider in analysis #3545

RealAnna opened this issue Jun 4, 2024 · 0 comments
Labels
enhancement New feature or request metrics-operator

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Jun 4, 2024

this ticket overlaps a bit with #2790

typical API errors look like:


{
  "error": {
    "code": 400,
    "message": "Constraints violated.",
    "details": {
      "errorRef": "f81d4fae-7dec-11d0-a765-00a0c91e6bf6",
      "traceId": "99633483d17779d7c81141f50dbc2a49",
      "errorCode": "InvalidPaginationToken",
      "constraintViolations": [
        {
          "path": "detectionRules[0].filterConfig.pattern",
          "message": "may not be null",
          "parameterLocation": "PAYLOAD_BODY"
        }
      ]
    }
  }
}

it would help debugging if we could also export the details in the analysis CRD error message, the current error message propagation does not help users understand their errors.

We should also specify how the metric providers queries the API , already using the 'metricsSelector=' a proper blog/ DT tutorial is needed for this probably.

DoD

  • add details in error struct and return them in the provider logs + metric status
  • avoid user error by trimming metricsSelector= prefix if the query starts with it
@RealAnna RealAnna added enhancement New feature or request and removed bug Something isn't working status: needs-discussion labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request metrics-operator
Projects
None yet
Development

No branches or pull requests

1 participant