Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain that part-of and name annotations are concatenated #3778

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

Garvit-77
Copy link
Contributor

Summary

  • adding a NOTE to integrate.md
  • adding the Note to the architectural with a brief explanation

Fixes #3540

Checks

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

@Garvit-77 Garvit-77 requested review from a team as code owners October 25, 2024 22:14
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2024
@mowies mowies changed the title Explain that part-of and name annotations are concatenated docs: explain that part-of and name annotations are concatenated Oct 28, 2024
docs/docs/guides/integrate.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/keptn-apps.md Outdated Show resolved Hide resolved
docs/docs/components/lifecycle-operator/keptn-apps.md Outdated Show resolved Hide resolved
@mowies
Copy link
Member

mowies commented Oct 28, 2024

@Garvit-77 please fix the failing lint check, then this PR should be ready to merge

Garvit-77 and others added 7 commits October 29, 2024 15:17
Signed-off-by: Garvit Khandelwal <garvitname@gmail.com>
Signed-off-by: Garvit Khandelwal <garvitname@gmail.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
Signed-off-by: Garvit Khandelwal <70192868+Garvit-77@users.noreply.github.com>
docs/docs/components/lifecycle-operator/keptn-apps.md Outdated Show resolved Hide resolved
docs/docs/guides/integrate.md Outdated Show resolved Hide resolved
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Copy link

@mowies
Copy link
Member

mowies commented Oct 29, 2024

thanks @Garvit-77 !

@mowies mowies merged commit 59a19cc into keptn:main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain that part-of and name annotations are concatenated
3 participants