chore: enhance golangci-lint with code complexity and other measures #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mowies
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
==========================================
+ Coverage 59.68% 60.95% +1.26%
==========================================
Files 28 30 +2
Lines 2101 2177 +76
==========================================
+ Hits 1254 1327 +73
- Misses 743 745 +2
- Partials 104 105 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove redundant newlines Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove code quality tools reporting Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> adjust funlen go linter Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> also trigger golangci-lint on pushes to main and maintenance branches Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> set up complexity and function length measure for golangci-lint Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> comment in stuff Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> more debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> more debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> debugging Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove trailing slashes Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove prefixes on coverage reports Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> even more trys Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> one more Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> another try... Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> fix coverage files in makefile Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> one more try Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove lines that are not needed again Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove unneeded lines from coverage reports Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> comment out stuff Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> upload to code climate as well Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> adjust path Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> set up token correctly Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> rename Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> change coverage reporting Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> remove bug Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com> report coverage to codacy Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
requested review from
thisthat,
thschue,
bacherfl,
RealAnna and
philipp-hinteregger
as code owners
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
force-pushed
the
enhance-golinter
branch
from
a7cb2f5
to
2babde5
Compare
Closed
odubajDT
reviewed
Nov 30, 2022
|
looks good, but is there maybe a possibility to disable the checks on the *_test.go files ? Now we have errors that some test functions are too long, which is completely ok for us, as we are mostly using table tests |
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
odubajDT
previously approved these changes
Nov 30, 2022
philipp-hinteregger
previously approved these changes
Nov 30, 2022
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
dismissed stale reviews from philipp-hinteregger and odubajDT
via
427df59
philipp-hinteregger
previously approved these changes
Dec 1, 2022
odubajDT
previously approved these changes
Dec 1, 2022
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
mowies
dismissed stale reviews from odubajDT and philipp-hinteregger
via
d93a4e6
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
thisthat
previously approved these changes
Dec 1, 2022
odubajDT
previously approved these changes
Dec 1, 2022
Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Dec 1, 2022
odubajDT
approved these changes
Dec 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
cyclop: Measures and limits cyclomatic complexitygocognit: Measures and limits cognitive complexityfunlen: Limits function line and statement lengthtestcommands to return aggregated and fully syntactically correct coverage reportsNotes:
Closes #462
Linter issues will be fixed in #485.