Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query jobs before creating #79

Merged
merged 3 commits into from
Sep 30, 2022
Merged

fix: query jobs before creating #79

merged 3 commits into from
Sep 30, 2022

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Sep 30, 2022

Signed-off-by: Thomas Schuetz thomas.schuetz@dynatrace.com

Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
@RealAnna
Copy link
Contributor

Since we do not use the job name We can remove this line and the consequent update
now? https://github.com/keptn-sandbox/lifecycle-controller/blob/07418e00c5617613453ecaa2edaa064b5293c74d/operator/controllers/keptntask/job_utils.go#L92

Signed-off-by: Thomas Schuetz <thomas.schuetz@dynatrace.com>
@thschue
Copy link
Contributor Author

thschue commented Sep 30, 2022

Since we do not use the job name We can remove this line and the consequent update now?

https://github.com/keptn-sandbox/lifecycle-controller/blob/07418e00c5617613453ecaa2edaa064b5293c74d/operator/controllers/keptntask/job_utils.go#L92

No, as it's nice to have the jobname in the status

Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and verified on my cluster - now the task controller does not create duplicate jobs for the same task anymore

Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thschue thschue merged commit 47f82b8 into main Sep 30, 2022
@thschue thschue deleted the fix/duplicate_job_starts branch September 30, 2022 12:10
This was referenced Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants