Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from Datasets to TFDS for GLUE Example #340

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Migrating from Datasets to TFDS for GLUE Example #340

merged 4 commits into from
Sep 7, 2022

Conversation

aflah02
Copy link
Collaborator

@aflah02 aflah02 commented Sep 3, 2022

Resolves #333

mattdangerw
mattdangerw requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple comments.

examples/bert/bert_finetune_glue.py Outdated Show resolved Hide resolved
examples/bert/bert_finetune_glue.py Outdated Show resolved Hide resolved
examples/bert/bert_finetune_glue.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment, then all good!

examples/bert/bert_finetune_glue.py Outdated Show resolved Hide resolved
mattdangerw
mattdangerw approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! we have some test failures so won't merge this quite yet, but as soon as our ci is working again!

@mattdangerw
Copy link
Member

OK unblocked on ci!

@mattdangerw mattdangerw merged commit 817d1c2 into keras-team:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdangerw mattdangerw mattdangerw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update our glue evaluation script to use tensorflow datasets
2 participants
@aflah02 @mattdangerw