-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options.node_env
that refers process.env.NODE_ENV
by default
#6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, don't forget to squash your commits into a single one, and please follow the angular commit message conventions, because we use conventional-changelog to generate the CHANGELOG.md
when releasing a new versions. Also you can refer the issue #5 in your commit message.
Summarizing the above, I want this PR to be a single commit with message like:
feat(options): add `options.node_env` implementation, closes #5
options.node_env
that refers process.env.NODE_ENV
by default
as per suggestion Co-Authored-By: solaris765 <bassvaulter@gmail.com>
I've made all the changes we talked about above. But in the process we did end up removing the line that sets Should I replace the setter that we removed or leave setting NODE_ENV up to the user? |
Test shouldn't be changed on removing |
Un-related to the code, but what would be the best option for addressing the original issue you presented? to follow angular commit standards would the best option after the other issues are fixed to re-submit a new pull request or is there a way to address that here? (to be honest I don't have much experience contributing to other's projects on github and I really appreciate your patience with me thus far) |
Co-Authored-By: solaris765 <bassvaulter@gmail.com>
You can try to |
ok, I'll try that after I finish |
Or maybe it would be better to try squash merge PR with github. Leave it as is for now. |
Yes, exactly, we can do squash merge 👍 |
ok, I think its ready for review number 2. (its also getting late for me, so if there are anymore changes that need to be made I'll probably address them tomorrow) |
Everything else looks perfect 👍 |
Co-Authored-By: solaris765 <bassvaulter@gmail.com>
@solaris765, good job 👍 |
Awesome! Done! |
Add documentation for the `node_env` initialization option implemented in PR #6
@solaris765, I've released a new candidate $ npm install "dotenv-flow@latest" or $ yarn add dotenv-flow Let me know if you find any related bugs. |
Got it. I'll try it now. I have a use case that's currently referencing an earlier version of my git fork that I can move over for testing |
I went ahead and put together the changes we talked about in issue 5.
If this is up to standards and keeps within the goals of this module please consider reviewing.
Thanks!