Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get and Set Configuration need fixing #63

Open
arlolra opened this issue Mar 14, 2017 · 0 comments
Open

Get and Set Configuration need fixing #63

arlolra opened this issue Mar 14, 2017 · 0 comments
Labels

Comments

@arlolra
Copy link
Collaborator

arlolra commented Mar 14, 2017

See 9c40f4d

SetConfiguration pretty much always returns INVALID_MODIFICATION because of the following, from webrtc/pc/peerconnection.cc,

  // The simplest (and most future-compatible) way to tell if the config was
  // modified in an invalid way is to copy each property we do support
  // modifying, then use operator==. There are far more properties we don't
  // support modifying than those we do, and more could be added.
  RTCConfiguration modified_config = configuration_;
  modified_config.servers = configuration.servers;
  modified_config.type = configuration.type;
  modified_config.ice_candidate_pool_size =
      configuration.ice_candidate_pool_size;
  modified_config.prune_turn_ports = configuration.prune_turn_ports;
  modified_config.ice_check_min_interval = configuration.ice_check_min_interval;
  if (configuration != modified_config) {
    LOG(LS_ERROR) << "Modifying the configuration in an unsupported way.";
    return SafeSetError(RTCErrorType::INVALID_MODIFICATION, error);
  }

GetConfiguration needs to return more than just the go object so that can be called with a complete set of values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant