Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpritePropertyEditorDialog deletes the originalSpritePixmap pointer which makes it necessary to dynamically reinitialize spritePixmap for each object. #6

Open
keshav2010 opened this issue May 28, 2018 · 0 comments
Labels
Implementation Issue Poor implementation that can lead to potential bugs and crashes refactoring

Comments

@keshav2010
Copy link
Owner

keshav2010 commented May 28, 2018

This is a poor implementation which makes it hard to keep track of references as they are passed to various objects as function arguments, and might lead to potential memory leak or segmentation fault issues. The one way to fix the issue is to keep the dialog alive for the entire lifetime of the program, i.e in memory instead of freeing up the used memory.

@keshav2010 keshav2010 added the Implementation Issue Poor implementation that can lead to potential bugs and crashes label May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation Issue Poor implementation that can lead to potential bugs and crashes refactoring
Projects
None yet
Development

No branches or pull requests

1 participant