From a17d19ad163c16f7e4499692485d63cd41684914 Mon Sep 17 00:00:00 2001 From: Ludovic DEHON Date: Mon, 3 Oct 2022 21:30:40 +0200 Subject: [PATCH] chore(core): remove some compilation warning --- .../java/io/kestra/core/models/triggers/types/Schedule.java | 1 + .../main/java/io/kestra/core/tasks/scripts/BashService.java | 4 +--- core/src/main/java/io/kestra/core/tasks/storages/Concat.java | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java b/core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java index f78b55ae11..91d1d5b6b0 100644 --- a/core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java +++ b/core/src/main/java/io/kestra/core/models/triggers/types/Schedule.java @@ -130,6 +130,7 @@ public class Schedule extends AbstractTrigger implements PollingTriggerInterface title = "The time zone id to use for evaluate cron. Default value is the server default zone id." ) @PluginProperty(dynamic = true) + @Builder.Default private String timezone = ZoneId.systemDefault().toString(); @Schema( diff --git a/core/src/main/java/io/kestra/core/tasks/scripts/BashService.java b/core/src/main/java/io/kestra/core/tasks/scripts/BashService.java index 0f98ba685c..c1d43bb2bf 100644 --- a/core/src/main/java/io/kestra/core/tasks/scripts/BashService.java +++ b/core/src/main/java/io/kestra/core/tasks/scripts/BashService.java @@ -24,7 +24,7 @@ abstract public class BashService { protected static final ObjectMapper MAPPER = JacksonMapper.ofJson(); - private static final Pattern PATTERN = Pattern.compile("^::(\\{.*\\})::$"); + private static final Pattern PATTERN = Pattern.compile("^::(\\{.*})::$"); public static List finalCommandsWithInterpreter( String interpreter, @@ -104,8 +104,6 @@ private static void validFilename(String s) { } public static Map transformInputFiles(RunContext runContext, @NotNull Object inputFiles) throws IllegalVariableEvaluationException, JsonProcessingException { - Map finalInputFiles; - if (inputFiles instanceof Map) { //noinspection unchecked return (Map) inputFiles; diff --git a/core/src/main/java/io/kestra/core/tasks/storages/Concat.java b/core/src/main/java/io/kestra/core/tasks/storages/Concat.java index 4809d13d90..f08e3d3104 100644 --- a/core/src/main/java/io/kestra/core/tasks/storages/Concat.java +++ b/core/src/main/java/io/kestra/core/tasks/storages/Concat.java @@ -98,13 +98,13 @@ public class Concat extends Task implements RunnableTask { @PluginProperty(dynamic = true) private String separator; + @SuppressWarnings("unchecked") @Override public Concat.Output run(RunContext runContext) throws Exception { File tempFile = runContext.tempFile().toFile(); try (FileOutputStream fileOutputStream = new FileOutputStream(tempFile)) { List finalFiles; if (this.files instanceof List) { - //noinspection unchecked finalFiles = (List) this.files; } else if (this.files instanceof String) { final TypeReference> reference = new TypeReference<>() {};