Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top navigation on the editor don't follow the themes #4569

Closed
tchiotludo opened this issue Aug 5, 2024 · 2 comments · Fixed by #4669
Closed

Top navigation on the editor don't follow the themes #4569

tchiotludo opened this issue Aug 5, 2024 · 2 comments · Fixed by #4669
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working kind/quick-win Seems to be quick to do

Comments

@tchiotludo
Copy link
Member

See on the christian video:
image
the top navigation is dark grey and not bluish like the background off the editor

@github-project-automation github-project-automation bot moved this to Backlog in Issues Aug 5, 2024
@tchiotludo tchiotludo added bug Something isn't working area/frontend Needs frontend code changes kind/quick-win Seems to be quick to do labels Aug 5, 2024
@MilosPaunovic
Copy link
Member

If you mean the top 5 lines of code, starting from tasks and ending with inputs, that is what's called Sticky Scroll functionality of the Monaco Editor we're using, see https://learn.microsoft.com/en-us/visualstudio/ide/editor-sticky-scroll?view=vs-2022 for more details.

The same behaviour is default in VSCode, it's something users are used to, so, in my opinion, we should either keep it like this, with the default colour highlighting provided by editor or disable that functionality as a whole - meaning, it will be very confusing if we leave the functionality in but don't highlight that segment of code with different colour/shadow.

WDYT @tchiotludo?

@tchiotludo
Copy link
Member Author

tchiotludo commented Aug 6, 2024

Yes I know for the sticky feature.
Just in vscode, the background color from the sticky section is the same one than the editor.
This dark background for the sticky part is not really visually clean

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working kind/quick-win Seems to be quick to do
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants