Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Refactor trigger variables data to use the same columnar expand-collapse format as in the Outputs tab #4643

Closed
anna-geller opened this issue Aug 12, 2024 · 2 comments · Fixed by #5519
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

anna-geller commented Aug 12, 2024

Feature description

we need to implement a similar output handling for Trigger variables as we did here for the Outputs tab #1528 (comment)

Old:
image

especially painful with webhook triggers with many variables in the payload:

image


Should be:
image

@MilosPaunovic I think Figma is missing, but perhaps you can still figure it out? https://www.figma.com/design/ew0uXk0NRXJ2NBBJTNe2n1/01_UI?node-id=0-1&t=wsaCI9aAscJmjTt9-0

@anna-geller anna-geller added enhancement New feature or request area/frontend Needs frontend code changes labels Aug 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Aug 12, 2024
@anna-geller anna-geller added kind/highlight One of the highlights of the upcoming release and removed kind/highlight One of the highlights of the upcoming release labels Aug 15, 2024
@anna-geller
Copy link
Member Author

FYI moved to 0.20 as there is only 1 week left before the release

@anna-geller anna-geller added the good first issue Great issue for new contributors label Oct 10, 2024
@Ben8t
Copy link
Member

Ben8t commented Oct 16, 2024

@MilosPaunovic here is a flow generating nested trigger values and outputs

id: many_nested
namespace: company.team

variables:
  test: test
  test2: test2
  test3: test3

inputs:
  - id: test
    type: SELECT
    values: ["TEST", "TEST2", "TEST3"]


tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

outputs:
  - id: test
    type: SELECT
    value: ["TEST", "TEST2", "TEST3"]

triggers:
  - id: query
    type: io.kestra.plugin.jdbc.postgresql.Trigger
    interval: PT30S
    password: k3str4
    fetch: true
    fetchType: STORE
    sql: "select * from pg_namespace"
    url: jdbc:postgresql://postgres:5432/kestra
    username: kestra

Currently variables and inputs are not displayed on the execution overview. (beware the flow is triggering every 30 secs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants