Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of Type I/II TSRK methods #15

Open
ketch opened this issue Feb 20, 2015 · 9 comments
Open

Add examples of Type I/II TSRK methods #15

ketch opened this issue Feb 20, 2015 · 9 comments

Comments

@ketch
Copy link
Owner

ketch commented Feb 20, 2015

There are functions written specifically for these methods, but no examples or tests using them.

@ketch
Copy link
Owner Author

ketch commented Feb 20, 2015

Some methods are available in this paper: http://www.davidketcheson.info/assets/papers/2011_tsrk.pdf
See Appendix A.

@ketch ketch added the ready label Feb 23, 2015
@sconde
Copy link
Contributor

sconde commented Feb 25, 2015

The methods given in the appendix are coefficient of the low storage form. The current status of the TSRK class doesn't have any methods to handle these coefficients. I have an advection example that seems to work but I'm using definition (4.3) in the paper. Is this ok?

@ketch
Copy link
Owner Author

ketch commented Feb 26, 2015

@sconde You're right. That low-storage form is, of course, just the canonical Shu-Osher form for TSRKs. I think the right thing to do is implement a shu_osher_to_butcher function for TSRKs (it will be similar to the one for RKs). I believe this requires inverting the equations that appear below (4.3) in the paper.

@ketch ketch added in progress and removed ready labels Feb 26, 2015
@sconde
Copy link
Contributor

sconde commented Mar 1, 2015

@ketch, perhaps I'm confused but it seems that a step method is needed. Should I write this for tsrk?

@ketch
Copy link
Owner Author

ketch commented Mar 1, 2015

You are absolutely right that no step method has been implemented for TSRKs. That would be a very nice contribution!

Of course, examples of TSRKs can be added whether or not we have a step method.

@sconde
Copy link
Contributor

sconde commented Mar 24, 2015

@ketch It wasn't my intention to delete any code. I was trying out an idea that may have accidentally been pushed to my master branch rather than my "develop" branch. I shall push the example and my attempt at the step method once I've completed them.

@ketch
Copy link
Owner Author

ketch commented Mar 25, 2015

Yeah, that's what I thought. It's no problem; I just wanted to point it out because I wasn't sure you were aware. I'm looking forward to the new PR!

@sconde
Copy link
Contributor

sconde commented Apr 3, 2015

@ketch I'll like to check that my new addition is working, with both fixed-timestep and adpative-time step. Which test would you recommend I run before a PR?

@ketch
Copy link
Owner Author

ketch commented Apr 4, 2015

Try running a convergence test and a "performance test" with them on any of the nonlinear problems. See convergence.py and ivp.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants