-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples of Type I/II TSRK methods #15
Comments
Some methods are available in this paper: http://www.davidketcheson.info/assets/papers/2011_tsrk.pdf |
The methods given in the appendix are coefficient of the low storage form. The current status of the TSRK class doesn't have any methods to handle these coefficients. I have an advection example that seems to work but I'm using definition (4.3) in the paper. Is this ok? |
@sconde You're right. That low-storage form is, of course, just the canonical Shu-Osher form for TSRKs. I think the right thing to do is implement a |
@ketch, perhaps I'm confused but it seems that a step method is needed. Should I write this for tsrk? |
You are absolutely right that no Of course, examples of TSRKs can be added whether or not we have a step method. |
@ketch It wasn't my intention to delete any code. I was trying out an idea that may have accidentally been pushed to my master branch rather than my "develop" branch. I shall push the example and my attempt at the step method once I've completed them. |
Yeah, that's what I thought. It's no problem; I just wanted to point it out because I wasn't sure you were aware. I'm looking forward to the new PR! |
@ketch I'll like to check that my new addition is working, with both fixed-timestep and adpative-time step. Which test would you recommend I run before a PR? |
Try running a convergence test and a "performance test" with them on any of the nonlinear problems. See convergence.py and ivp.py. |
There are functions written specifically for these methods, but no examples or tests using them.
The text was updated successfully, but these errors were encountered: