Implementing preset modes - Manual, Scheduled and Vacation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports Manual, Scheduled and Automatic modes Additionally fixes a few bits of spelling.
devchristof
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Danfoss Eco2 thermostats offer 4 different modes: Manual, Scheduled, Vacation - and Hold, which puts it in frost protection mode. This mode is not normally available from the app that I know of, but it does work fine with it.
This PR adds the ability to control the first 3 modes through MQTT, and I have tried it out using Home Asisstant.
It also has a few corrections in spelling and naming where I had happened across them.
I had not managed to get the tests running locally, so those have not been modified. I have tested in a live environment instead :-)