Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where are the 2.10 dist files? #847

Closed
eradin opened this issue Nov 1, 2018 · 6 comments · Fixed by #851
Closed

Where are the 2.10 dist files? #847

eradin opened this issue Nov 1, 2018 · 6 comments · Fixed by #851

Comments

@eradin
Copy link

eradin commented Nov 1, 2018

Previously there were min files for the js. I don't see that.

Thank you.

@kevinchappell
Copy link
Owner

dist files were removed from the repo to prevent huge changes on each PR, is this causing a problem? The npm install still includes /dist, just not the repo

@eradin
Copy link
Author

eradin commented Nov 1, 2018

Didn't know that. I grabbed them from npm and I see the min files. Previous versions also had a control_plugin folder. I am not using those but if anybody is, they are missing in the dist folder.

@kevinchappell
Copy link
Owner

Oh thanks, those should be included. Will release 2.10.1 that includes them

@eradin
Copy link
Author

eradin commented Nov 4, 2018

I hate to rehash this but the plugins are still not there. The dist folder is now there but no plugin folder. Was it eliminated?

@kevinchappell
Copy link
Owner

ah youre right. I need to add it to npm.files for for control_plugins to be published. reopening until resolved

@kevinchappell kevinchappell reopened this Nov 4, 2018
@kevinchappell
Copy link
Owner

This is fixed in 2.10.4
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants