Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the edm4hep::ObjectID from the datamodel #259

Closed
tmadlener opened this issue Feb 1, 2024 · 0 comments · Fixed by #260
Closed

Remove the edm4hep::ObjectID from the datamodel #259

tmadlener opened this issue Feb 1, 2024 · 0 comments · Fixed by #260

Comments

@tmadlener
Copy link
Contributor

Currently edm4hep defines its own ObjectID:

EDM4hep/edm4hep.yaml

Lines 110 to 120 in 66c90fc

#------ ObjectID helper struct for references/relations
edm4hep::ObjectID:
Members:
- int32_t index
- int32_t collectionID
ExtraCode:
includes: "#include <podio/ObjectID.h>\n"
declaration: "
ObjectID() = default;\n
ObjectID(const podio::ObjectID& id ): index(id.index), collectionID(id.collectionID) {}\n
"

This is slightly different from the podio one which basically boils down to

struct ObjectID {
  int index;
  uint32_t collectionID;
};

As far as I can tell this is actually unused and we should be able to achieve the same (intended) functionality.

@tmadlener tmadlener moved this from Todo to In Progress in EDM4hep v1.0 Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in EDM4hep v1.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant