You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a few more or less subtle differences with some integer type data members or functions returning integer type values. This is an unordered list of these and the main point of this issue is to have this list available such that it can be put into documentation at some point.
Return types of SimCalorimeterHit::getNMCContributions is int, but in EDM4hep these are OneToManyRelations so the corresponding call to SimCalorimeterHit::getContributions()::size returns a size_t.
The handling of CellIDs is somewhat inconsistent in LCIO as in quite a few cases there is an int getCellID and additional versions for getCellID0 and getCellID1 both returning 32 bit integers from which it is possible to construct the uint64_t cellID from edm4hep.
The TPCHit in LCIO does only have an int cellID, no other overloads. It still has a uint64_t CellID in the edm4hep::RawTimeSeries.
The LCEvent::getTimeStamp is long64 in LCIO, but a uint64_t in the edm4hep::EventHeader. (This might be something that we could consider fixing?) Event timestamps will always be positive (no relative time). Not fixing this, document only.
The text was updated successfully, but these errors were encountered:
There are a few more or less subtle differences with some integer type data members or functions returning integer type values. This is an unordered list of these and the main point of this issue is to have this list available such that it can be put into documentation at some point.
SimCalorimeterHit::getNMCContributions
isint
, but in EDM4hep these areOneToManyRelations
so the corresponding call toSimCalorimeterHit::getContributions()::size
returns asize_t
.CellID
s is somewhat inconsistent in LCIO as in quite a few cases there is anint getCellID
and additional versions forgetCellID0
andgetCellID1
both returning 32 bit integers from which it is possible to construct theuint64_t cellID
from edm4hep.SimTrackerHit
,SimCalorimeterHit
,CalorimeterHit
,TrackerHit
,TrackerHitPlane
,RawCalorimeterHit
TPCHit
in LCIO does only have anint
cellID, no other overloads. It still has auint64_t
CellID in theedm4hep::RawTimeSeries
.LCEvent::getTimeStamp
islong64
in LCIO, but auint64_t
in theedm4hep::EventHeader
.(This might be something that we could consider fixing?)Event timestamps will always be positive (no relative time). Not fixing this, document only.The text was updated successfully, but these errors were encountered: