Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights vector to EventHeader and constant for storing them #254

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jan 22, 2024

BEGINRELEASENOTES

  • Add a double weight VectorMember to the EventHeader to allow storing multiple weights.
    • This should not break any existing code as we simply add a new member. However, this will break the possibility of reading existing files through podio.
  • Introduce the edm4hep::EventWeights constant to have a consistent name for storing / accessing them in file level metadata.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

As discussed during the meeting on Jan 23 we also make the nominal weight of the EventHeader a double for consistency.

edm4hep.yaml Outdated Show resolved Hide resolved
@jmcarcell jmcarcell enabled auto-merge (squash) February 22, 2024 08:37
@jmcarcell jmcarcell merged commit 83b6c4a into key4hep:main Feb 22, 2024
12 of 13 checks passed
@tmadlener tmadlener deleted the multiple-weights branch February 22, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ways to store multiple event weights
2 participants