Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #272 breaks refresh of existing state #283

Closed
dmeyerholt opened this issue May 11, 2020 · 4 comments · Fixed by #284
Closed

PR #272 breaks refresh of existing state #283

dmeyerholt opened this issue May 11, 2020 · 4 comments · Fixed by #284
Labels
bug Something isn't working

Comments

@dmeyerholt
Copy link
Contributor

Hi,
during testing the current master tree' terraform refresh on a rather large state, it aborted with several
Error: strconv.ParseBool: parsing "": invalid syntax
errors. This seems to be related to PR #272 and commit 2bf367a . maybe specifically this line https://github.com/mrparkers/terraform-provider-keycloak/blob/2bf367a0d330fe169511c53a4c1fff70e6a0d072/keycloak/openid_user_attribute_protocol_mapper.go#L68 ? reverting this locally makes everything good again. somebody else have the same issue or am I missing something here?
Our installation: Keycloak 6.0.1 , provider: current master

Best
@mrparkers
Copy link
Contributor

Hey @dmeyerholt, sorry that this is happening to you.

I tried to reproduce this by running Keycloak 6.0.1 and applying the configuration in example/main.tf which includes a few of the resources that appear to be causing you problems, and I wasn't able to reproduce it.

Could you help me out by providing some sample HCL that reproduces this?

@mrparkers mrparkers added bug Something isn't working question Further information is requested labels May 11, 2020
@mrparkers
Copy link
Contributor

Nevermind, I was able to reproduce it. I can work on a fix, thanks for the bug report!

@mrparkers mrparkers removed the question Further information is requested label May 11, 2020
@mrparkers mrparkers mentioned this issue May 11, 2020
Merged
@mrparkers
Copy link
Contributor

@dmeyerholt let me know if the current master branch fixed your issue. If it doesn't, feel free to reopen this.

@dmeyerholt
Copy link
Contributor Author

Everything is fine now, thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@dmeyerholt @mrparkers