Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(common/web): improve null handling and initialisation of KvkFileWriter #12809

Open
1 of 8 tasks
markcsinclair opened this issue Dec 9, 2024 · 0 comments · May be fixed by #12810
Open
1 of 8 tasks

bug(common/web): improve null handling and initialisation of KvkFileWriter #12809

markcsinclair opened this issue Dec 9, 2024 · 0 comments · May be fixed by #12810
Assignees
@markcsinclair
Labels
bug common/web/ common/ web/
Milestone
A18S17

Comments

@markcsinclair
Copy link
Contributor

markcsinclair commented Dec 9, 2024 •
edited
Loading

Describe the bug

There are problems with null handling of associatedKeyboard, key ansiFont.name and unicodeFont.name in KvkFileWriter, plus incorrect initialisation of BUILDER_KVK_STRING, which should be { len: 1, str: '' } not { len: 0, str: '' }.

Test cases have been written in PR #12734 to cover the three null strings, but are commented out as they fail.

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markcsinclair markcsinclair

Labels
bug common/web/ common/ web/
Projects
Keyman
Status: No status
Milestone
A18S17
Development

Successfully merging a pull request may close this issue.

fix(common/web): improve null handling and initialisation of KvkFileWriter keymanapp/keyman
2 participants
@ermshiperete @markcsinclair