fix(common/web): improve null handling and initialisation of KvkFileWriter #12810
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
markcsinclair
changed the base branch from
master
to
test/common/web/types/9052-unit-tests-kvk-file-writer
mcdurdin
reviewed
Dec 9, 2024
Base automatically changed from
test/common/web/types/9052-unit-tests-kvk-file-writer
to
master
December 10, 2024 10:47
…809-improve-null-handling-and-initialisation-of-KvkFileWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve null handling of
associatedKeyboard, keyansiFont.nameandunicodeFont.nameinKvkFileWriter, plus incorrect initialisation of BUILDER_KVK_STRING, which should be{ len: 1, str: '' }not{ len: 0, str: '' }.Test cases included to cover the three null strings.
Fixes: #12809
@keymanapp-test-bot skip