Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI signature verification output #13

Open
BTBurke opened this issue May 14, 2020 · 3 comments
Open

CLI signature verification output #13

BTBurke opened this issue May 14, 2020 · 3 comments

Comments

@BTBurke
Copy link

BTBurke commented May 14, 2020

Hi @gabriel

I want to use keys to sign a SHA256 hash of a binary, but the UX seems off to me. As far as I can tell so far, there is no output when the signature is successfully verified. The only obvious sign that it did something is a 0 exit code.

I started with this:

sha256sum mybinary | keys sign -s btburke@github -m armor,detached > mybinary.sig

Then verified with this:

sha256sum mybinary | keys verify -s btburke@github -x mybinary.sig

That works, because I get "verify failed" if I make a change to the binary.

But, from a user experience perspective I think it would inspire more confidence if a successful verification also had something on stdout, with maybe a -q, --quiet flag to only look at the return code.

@gabriel
Copy link
Contributor

gabriel commented May 15, 2020

Yeah adding in a --quiet option sounds like a good idea.

@BTBurke
Copy link
Author

BTBurke commented May 19, 2020

I think the bigger issue is the lack of any output when you verify something. For example, if I sign a file with minisign, I get a nice console output saying that the signature is valid, time, comment, etc.

$ minisign -V -m test.txt
Signature and comment signature verified
Trusted comment: timestamp:1589922579	file:test.txt

The other nice thing about the minisign UX is that there is an option to hash large files and then sign the hash instead of the whole file.

@gabriel
Copy link
Contributor

gabriel commented May 22, 2020

Saltpack sign v2 supports streaming in the case of large files, https://saltpack.org/signing-format-v2.

I haven't looked into supporting comments and time and nicer output but those sound like good improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants