Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is unusable until the page loads #28

Closed
simonhearne opened this issue May 10, 2017 · 3 comments · Fixed by #37
Closed

Extension is unusable until the page loads #28

simonhearne opened this issue May 10, 2017 · 3 comments · Fixed by #37

Comments

@simonhearne
Copy link
Contributor

On slower pages such as http://www.dailymail.co.uk/home/index.html it is quite likely that a user will click on the extension before the page completes loading. In this case there is no Start button and no indication why. The start button does not appear when the page does load, giving the impression that the extension is broken.

@tabanliviu
Copy link
Contributor

The issue is that the content script of the extension is added on document_idle to not interfere with the page. https://developer.chrome.com/extensions/content_scripts#run_at

@tabanliviu
Copy link
Contributor

@simonhearne is this an issue? please prioritize or close

@simonhearne
Copy link
Contributor Author

Yes, we should at least have a 'please wait while the page loads...' message, then load the button asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants