Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the route is changed by javascript, the image-checker is not re-triggered. #31

Closed
robertdumitrescu opened this issue May 11, 2017 · 2 comments
Milestone

Comments

@robertdumitrescu
Copy link

robertdumitrescu commented May 11, 2017

For instance on this site: (http://www.vebleno.com/) if I activate the image-efficiency-checker and I go on any other route by clicking on the gray bars, the plugin doesn't re-check the currently displayed images.

Screenshot:

screenshot from 2017-05-11 14-44-43

@simonhearne
Copy link
Contributor

This is true of resize events and still events too. I suggest we use the resize and mutation observer event listeners to trigger the script to rerun.

@tabanliviu
Copy link
Contributor

fixed in 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants