-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Location
field
#1736
Merged
Merged
Add new Location
field
#1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
Signed-off-by: Jordan Overbye <jordanoverbye@gmail.com>
🦋 Changeset is good to goLatest commit: e8806c9 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Will be a good addition to Keystone 5 |
MadeByMike
approved these changes
Oct 7, 2019
@@ -0,0 +1,11 @@ | |||
// @flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using flow or not?
Mate, I love this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a new
Location
field which stores data about a particular location data using the Google Maps API.Below is a basic flow of how the field works in the Admin UI (there are also testing instructions and screenshots below):
value
of each suggestion is aGoogle Place ID
.Google Place ID
to make a client-side request is made to the Google Maps Geoode API. This will return the formatted address, lat, lng etc. Once we have this information we show the user a map with a pin and also updated the input value to the formatted address.Google Place ID
is sent to the server, and the server will do its own request to get the lat, lng, formatted address etc - which will then get saved into the DB. The reason this happens again on the server is so we only have to send aGoogle Place ID
to create a Location field. I think this would be handy for applications other than the AdminUI.Notes: I've had to update
@arch-ui/select
so that it allows us to use async and creatable react-selects through theisCreatable
andisAsync
props.Testing
This is a basic Keystone config which shows off how this new field works.
Screenshots
Searching
Search by business ...
Search by address ...
Once a location is selected, the select value will show the formatted address and will display map with a marker.
Editing a post with selected location
Cell view - just display the formatted address