Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for old encoding of equations #2890

Merged
merged 10 commits into from
Oct 27, 2021

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Oct 21, 2021

Fixes #2889

I want to emphasise that I had to remove one of our tests we got from a bug we fixed, issue-2244 , because the definition and spec were .kore (most likely we just used the bug report from the issue). For issue-2221 , I found a minimised example in the issue, which we probably should have used in the first place instead of the generated bug report.
Remember that when there are breaking changes in the frontend, there is no way to regenerate these tests, especially if the issue they came from is old, so we should only add K integration tests to our suite. Of course, this doesn't apply to our regression-evm and regression-kwasm tests, which we can regenerate.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sha3_bigSize.sh 0.000000 0.004057
test/regression-evm/test-sum-to-n.sh -0.000003 0
test/regression-evm/test-straight-line.sh 0.000000 0.041133
test/regression-evm/test-storagevar03.sh 0.000002 0.001591
test/regression-evm/test-straight-line-no-invalid.sh 0 0.003708
test/regression-evm/test-lemmas.sh -0.000016 0.015634
test/regression-evm/test-sumTo10.sh 0.000000 0.020429
test/regression-evm/test-totalSupply.sh 0.000001 -0.096407
test/regression-evm/test-pop1.sh 0 0.069836
test/regression-evm/test-branching-no-invalid.sh 0.000000 0
test/regression-evm/test-mul0.sh 0.000000 0.004528
test/regression-evm/test-branching-invalid.sh 0.000000 -0.066121
test/regression-evm/test-add0.sh -0.000000 0.021767
test/regression-evm/test-addu48u48.sh -0.000001 -0.014245
test/regression-evm/test-and0.sh 0.000000 -0.012528
test/regression-wasm/test-locals.sh -0.000000 0
test/regression-wasm/test-loops.sh -0.000025 0
test/regression-wasm/test-wrc20.sh 0.000006 -0.001391
test/regression-wasm/test-memory.sh 0.000007 0
test/regression-wasm/test-simple-arithmetic.sh 0.000003 -0.000001

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sha3_bigSize.sh 0.000000 0.000001
test/regression-evm/test-sum-to-n.sh 0.000003 -0.000000
test/regression-evm/test-straight-line.sh -0.000000 0.006192
test/regression-evm/test-storagevar03.sh 0.000019 -0.000097
test/regression-evm/test-straight-line-no-invalid.sh -0.000000 0.003708
test/regression-evm/test-lemmas.sh -0.000014 0.123561
test/regression-evm/test-sumTo10.sh 0.000000 -0.016512
test/regression-evm/test-totalSupply.sh -0.000001 0.024090
test/regression-evm/test-pop1.sh 0.000000 -0.035570
test/regression-evm/test-branching-no-invalid.sh 0.000000 -0.100789
test/regression-evm/test-mul0.sh -0.000000 0.097673
test/regression-evm/test-branching-invalid.sh -0.000000 -0.103905
test/regression-evm/test-add0.sh -0.000000 -0.000002
test/regression-evm/test-addu48u48.sh -0.000002 0.039000
test/regression-evm/test-and0.sh -0.000000 0.047256
test/regression-wasm/test-locals.sh -0.000000 0.000001
test/regression-wasm/test-loops.sh -0.000033 0
test/regression-wasm/test-wrc20.sh 0.000003 -0.002034
test/regression-wasm/test-memory.sh -0.000005 0
test/regression-wasm/test-simple-arithmetic.sh 0.000014 0.000000

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sha3_bigSize.sh 0.000001 0
test/regression-evm/test-sum-to-n.sh -0.000005 0.000015
test/regression-evm/test-straight-line.sh -0.000002 0.004988
test/regression-evm/test-storagevar03.sh 0.000008 -0.001467
test/regression-evm/test-straight-line-no-invalid.sh -0.000000 0.000002
test/regression-evm/test-lemmas.sh 0.000001 -0.091218
test/regression-evm/test-sumTo10.sh 0.000001 0.002040
test/regression-evm/test-totalSupply.sh 0.000015 0.078225
test/regression-evm/test-pop1.sh -0.000000 0.006232
test/regression-evm/test-branching-no-invalid.sh 0.000000 -0.026618
test/regression-evm/test-mul0.sh -0.000006 0.000132
test/regression-evm/test-branching-invalid.sh -0.000001 0.024191
test/regression-evm/test-add0.sh -0.000003 0.047728
test/regression-evm/test-addu48u48.sh -0.000002 -0.095258
test/regression-evm/test-and0.sh -0.000001 -0.088863
test/regression-wasm/test-locals.sh 0.000000 -0.000051
test/regression-wasm/test-loops.sh 0.000026 -0.000041
test/regression-wasm/test-wrc20.sh 0.000011 -0.005297
test/regression-wasm/test-memory.sh -0.000013 0.000031
test/regression-wasm/test-simple-arithmetic.sh -0.000008 0

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sha3_bigSize.sh 0.000000 -0.004040
test/regression-evm/test-sum-to-n.sh 0.000008 0.000001
test/regression-evm/test-straight-line.sh 0.000000 -0.006154
test/regression-evm/test-storagevar03.sh 0.000009 -0.002416
test/regression-evm/test-straight-line-no-invalid.sh -0.000000 -0.003694
test/regression-evm/test-lemmas.sh 0.000001 0.095797
test/regression-evm/test-sumTo10.sh -0.000000 0.006399
test/regression-evm/test-totalSupply.sh 0.000005 0.033075
test/regression-evm/test-pop1.sh 0.000000 0.040374
test/regression-evm/test-branching-no-invalid.sh -0.000000 -0.065444
test/regression-evm/test-mul0.sh 0 -0.000000
test/regression-evm/test-branching-invalid.sh 0.000000 -0.039516
test/regression-evm/test-add0.sh 0.000000 -0.073269
test/regression-evm/test-addu48u48.sh 0.000001 0.112611
test/regression-evm/test-and0.sh 0 0.037429
test/regression-wasm/test-locals.sh -0.000000 0.000001
test/regression-wasm/test-loops.sh 0.000003 0
test/regression-wasm/test-wrc20.sh -0.000020 0.004768
test/regression-wasm/test-memory.sh -0.000022 0
test/regression-wasm/test-simple-arithmetic.sh 0.000027 -0.000001

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-sha3_bigSize.sh 0.000001 -0.000001
test/regression-evm/test-sum-to-n.sh 0.000009 0.000045
test/regression-evm/test-straight-line.sh 0.000006 -0.014251
test/regression-evm/test-storagevar03.sh 0.000005 -0.005221
test/regression-evm/test-straight-line-no-invalid.sh 0.000003 -0.019637
test/regression-evm/test-lemmas.sh -0.000025 -0.000260
test/regression-evm/test-sumTo10.sh 0.000000 0.016511
test/regression-evm/test-totalSupply.sh 0.000004 -0.050930
test/regression-evm/test-pop1.sh -0.000000 -0.073858
test/regression-evm/test-branching-no-invalid.sh 0 0
test/regression-evm/test-mul0.sh -0.000000 0.000000
test/regression-evm/test-branching-invalid.sh -0.000001 -0.034905
test/regression-evm/test-add0.sh -0.000000 -0.023748
test/regression-evm/test-addu48u48.sh -0.000001 0.009932
test/regression-evm/test-and0.sh -0.000006 -0.067906
test/regression-wasm/test-locals.sh -0.000008 -0.000006
test/regression-wasm/test-loops.sh 0.000031 0.000152
test/regression-wasm/test-wrc20.sh 0.000017 0.002580
test/regression-wasm/test-memory.sh -0.000014 -0.000046
test/regression-wasm/test-simple-arithmetic.sh 0.000021 -0.000192

@rv-jenkins rv-jenkins merged commit 596aa6a into master Oct 27, 2021
@rv-jenkins rv-jenkins deleted the remove-old-equation-encoding branch October 27, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for old encoding of equations
3 participants