Skip to content
This repository has been archived by the owner on Mar 7, 2019. It is now read-only.

Adding support for minimum number of Fieldsets #249

Closed
Bl0kkie opened this issue Jan 20, 2015 · 19 comments
Closed

Adding support for minimum number of Fieldsets #249

Bl0kkie opened this issue Jan 20, 2015 · 19 comments
Assignees

Comments

@Bl0kkie
Copy link

Bl0kkie commented Jan 20, 2015

Next to the option of the max number of fieldsets it would be awesome to have a minimum also. Great to force a specific number of fieldsets when the design desires this.

@bradfloodx
Copy link

+1

1 similar comment
@alnicholl77
Copy link

+1

@kgiszewski
Copy link
Owner

I may have recently had the need for this as well.

So if I get a chance I'll add this functionality.

I'm thinking besides just raw number of fieldsets, the type might be considered as well in the use-case of multiple fieldsets.

@geoffbeaumont
Copy link

+1

2 similar comments
@dconlisk
Copy link

+1

@kennyburns1967
Copy link

+1

@owenblacker
Copy link

+1

2 similar comments
@StefanoChiodino
Copy link

+1

@argentini
Copy link

+1

@argentini
Copy link

It would be great to just add the minimum number first to get it in there quickly, and then evolve it to support deeper inspection. Just sayin!

@kjac
Copy link
Contributor

kjac commented Jun 20, 2017

@argentini (and everyone else) I've got a working feature branch for this. It validates the number of enabled fieldsets against a configurable minimum number of fieldsets. When we get around to creating a new release, this will probably go in there.

@kgiszewski
Copy link
Owner

Nice 😁

@kelvinschutz
Copy link

@kjac Is the feature branch on remote by chance? I ran into a need for minimum fieldsets lately and was thinking of having a go at it. I looked through your fork and here, but didn't see any branches with recent work on them for minimum fieldsets.

@kjac
Copy link
Contributor

kjac commented Jul 28, 2017

@kelvinschutz I have it in my local repo. I'm on vacation at the moment... will submit a PR as soon as I can, probably next week.

@kelvinschutz
Copy link

@kjac That's awesome! Let me know if there is any way I can assist :)

@kjac
Copy link
Contributor

kjac commented Aug 9, 2017

@kelvinschutz I'm going to play around with Archetype the next few days, it should be ready shortly.

Here's a sneak preview:

archetype-min-fieldsets

/cc @kgiszewski

@Bl0kkie
Copy link
Author

Bl0kkie commented Aug 9, 2017

@kjac Epic! Looks awesome already 👍

@kjac kjac self-assigned this Aug 9, 2017
@kelvinschutz
Copy link

@kjac This is excellent!

@kjac
Copy link
Contributor

kjac commented Aug 18, 2017

Added in v1.15.1

@kjac kjac closed this as completed Aug 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests