Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with CheckForTextualData #16

Open
g2petter opened this issue Feb 16, 2018 · 1 comment
Open

Possible issue with CheckForTextualData #16

g2petter opened this issue Feb 16, 2018 · 1 comment

Comments

@g2petter
Copy link

I'm not sure if it's correct to report this as an issue, but I ran into a problem with the CheckForTextualData function, in particular this check:

else if (rawData[i - 1] == 0 && rawData[i] < 10) { ++controlSequences; }

The char represented by the number 9 is Tab. I'm working with an ERP system that requires export files to be Tab-separated, so when I passed in an exported string with lots of tabs, it failed to pass this test. The solution was to check rawData[i] < 9 instead of rawData[i] < 10

@khalidsalomao
Copy link
Owner

Hi @g2petter , could you submit a PR with the fix and some test conditions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants