-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
largeVis embedding does not utilize n.cores argument #129
Comments
Hi @rrydbirk Have you tried setting the i.e. Line 47 in 61d0004
That's fed here: Line 703 in 61d0004
You'll see most of the methods in the Conos class expect that multiple cores will be accessible via that constructor, i.e. check the file here for I guess the revised logic to allow users to modify the |
On second thought, this logic is too contorted. We don't explicitly mention the If users want to change the number of cores, it's straightforward to do:
Please check if this works @rrydbirk. I could try to clarify in the documents. |
Hi @evanbiederstedt As I see it, the n.cores parameter should be passed:
From
From From
I'm not that experienced with C++ code, so I lose track of the |
Long story short, I'll need to play with the OpenMP directives here: https://github.com/kharchenkolab/conos/blob/main/src/largeVis.cpp#L210-L280 The parallelization is here:
|
I resolved this with some modifications to the openmp directives, i.e.
I'll include in the next version release |
Running
embedGraph(method = "largeVis", n.cores > 1)
only induces estimation of embedding using 1 core.The text was updated successfully, but these errors were encountered: