From 60905d6e18d74fe7e582ee2834bc73cece08e7d8 Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Thu, 10 Oct 2024 09:16:48 +0200 Subject: [PATCH] Temporarily consider 429s as success in links check (#6210) This considers 429s as a success, until we can get lychee to cache success requests even if there's a failure. This should only be a temporary measure. But ignoring one status code seems better than entirely disabling the check. Related: #6183. --- .github/workflows/links-fail-fast.yml | 3 ++- .github/workflows/links.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/links-fail-fast.yml b/.github/workflows/links-fail-fast.yml index 6df6c439030..be7c5b337ec 100644 --- a/.github/workflows/links-fail-fast.yml +++ b/.github/workflows/links-fail-fast.yml @@ -25,4 +25,5 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: fail: true - args: --max-concurrency 5 --cache --max-cache-age 1d . + # TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved + args: --max-concurrency 5 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 . diff --git a/.github/workflows/links.yml b/.github/workflows/links.yml index 623da0bc958..1d9e42f36f2 100644 --- a/.github/workflows/links.yml +++ b/.github/workflows/links.yml @@ -30,7 +30,8 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - args: --max-concurrency 1 --cache --max-cache-age 1d . + # TODO: Remove 429s exception once https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6183 is resolved + args: --max-concurrency 1 --cache --max-cache-age 1d --accept 100..=103,200..=299,429 . - name: Create Issue From File if: steps.lychee.outputs.exit_code != 0