From 97d510af8eb316f019237eef3a58748bf9a098af Mon Sep 17 00:00:00 2001 From: Maryam Saeidi Date: Fri, 30 Jun 2023 11:14:11 +0200 Subject: [PATCH] [AO] Remove default recovery messages for APM rule types (#160928) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #160926 Partially reverts https://github.com/elastic/kibana/pull/159571 ## Summary At the moment, we don't have any context for recovered alerts for APM rule types, and the default messages will be empty. We will bring these messages back after https://github.com/elastic/kibana/issues/158183 is done. ## 🧪 How to test - When creating an APM rule, add an action for the recovered state. You should see the default recovery message as Recovered (cherry picked from commit 3382061db4acd29c57f3b6def3e3008d46765a38) --- .../alerting/rule_types/register_apm_rule_types.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/x-pack/plugins/apm/public/components/alerting/rule_types/register_apm_rule_types.ts b/x-pack/plugins/apm/public/components/alerting/rule_types/register_apm_rule_types.ts index 48069b0a8fa57..7940a4128d809 100644 --- a/x-pack/plugins/apm/public/components/alerting/rule_types/register_apm_rule_types.ts +++ b/x-pack/plugins/apm/public/components/alerting/rule_types/register_apm_rule_types.ts @@ -16,13 +16,9 @@ import { import { ApmRuleType } from '../../../../common/rules/apm_rule_types'; import { anomalyMessage, - anomalyRecoveryMessage, errorCountMessage, - errorCountRecoveryMessage, transactionDurationMessage, - transactionDurationRecoveryMessage, transactionErrorRateMessage, - transactionErrorRateRecoveryMessage, } from '../../../../common/rules/default_action_message'; // copied from elasticsearch_fieldnames.ts to limit page load bundle size @@ -59,7 +55,6 @@ export function registerApmRuleTypes( }), requiresAppContext: false, defaultActionMessage: errorCountMessage, - defaultRecoveryMessage: errorCountRecoveryMessage, }); observabilityRuleTypeRegistry.register({ @@ -97,7 +92,6 @@ export function registerApmRuleTypes( ), requiresAppContext: false, defaultActionMessage: transactionDurationMessage, - defaultRecoveryMessage: transactionDurationRecoveryMessage, }); observabilityRuleTypeRegistry.register({ @@ -130,7 +124,6 @@ export function registerApmRuleTypes( }), requiresAppContext: false, defaultActionMessage: transactionErrorRateMessage, - defaultRecoveryMessage: transactionErrorRateRecoveryMessage, }); observabilityRuleTypeRegistry.register({ @@ -160,6 +153,5 @@ export function registerApmRuleTypes( }), requiresAppContext: false, defaultActionMessage: anomalyMessage, - defaultRecoveryMessage: anomalyRecoveryMessage, }); }