Merge pull request #278 from grzuy/move_all_deps_to_gemspec

Move all dependencies to gemspec out of Gemfile
rack · Mar 9, 2018 · c9cd023 · c9cd023
2 parents 922917d + 859c212
commit c9cd023
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 30 deletions.
diff --git a/Gemfile b/Gemfile
@@ -1,9 +1,3 @@
 source 'https://rubygems.org'
 
 gemspec
-
-group :development do
-  gem 'pry'
-  gem 'guard' # NB: this is necessary in newer versions
-  gem 'guard-minitest'
-end
diff --git a/gemfiles/dalli2.gemfile b/gemfiles/dalli2.gemfile
@@ -4,10 +4,4 @@ source "https://rubygems.org"
 
 gem "dalli", "~> 2.0"
 
-group :development do
-  gem "pry"
-  gem "guard"
-  gem "guard-minitest"
-end
-
 gemspec path: "../"
diff --git a/gemfiles/rails_4_2.gemfile b/gemfiles/rails_4_2.gemfile
@@ -5,10 +5,4 @@ source "https://rubygems.org"
 gem "activesupport", "~> 4.2.0"
 gem "actionpack", "~> 4.2.0"
 
-group :development do
-  gem "pry"
-  gem "guard"
-  gem "guard-minitest"
-end
-
 gemspec path: "../"
diff --git a/gemfiles/rails_5_0.gemfile b/gemfiles/rails_5_0.gemfile
@@ -5,10 +5,4 @@ source "https://rubygems.org"
 gem "activesupport", "~> 5.0.0"
 gem "actionpack", "~> 5.0.0"
 
-group :development do
-  gem "pry"
-  gem "guard"
-  gem "guard-minitest"
-end
-
 gemspec path: "../"
diff --git a/gemfiles/rails_5_1.gemfile b/gemfiles/rails_5_1.gemfile
@@ -5,10 +5,4 @@ source "https://rubygems.org"
 gem "activesupport", "~> 5.1.0"
 gem "actionpack", "~> 5.1.0"
 
-group :development do
-  gem "pry"
-  gem "guard"
-  gem "guard-minitest"
-end
-
 gemspec path: "../"
diff --git a/rack-attack.gemspec b/rack-attack.gemspec
@@ -34,4 +34,11 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'connection_pool'
   s.add_development_dependency 'memcache-client'
   s.add_development_dependency "timecop"
+  s.add_development_dependency 'pry'
+  s.add_development_dependency 'guard-minitest'
+  # Need to explicitly depend on guard because guard-minitest doesn't declare
+  # the dependency intentionally
+  #
+  # See https://github.com/guard/guard-minitest/pull/131
+  s.add_development_dependency 'guard'
 end