Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(participant): SKFP-650 use pheno.is_observed #3768

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Sep 22, 2023

###[FIX] Phenotype interpretation must used is_observed

SKFP-650

Description

Fix interpretation column in phenotype value from participant entity page to use phenotype.is_observed.

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

Capture d’écran, le 2023-09-22 à 11 06 27

After

Capture d’écran, le 2023-09-22 à 11 08 11

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit 4385007
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/650dadba241fc20008384a2d
😎 Deploy Preview https://deploy-preview-3768--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit 4385007
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/650dadba2f449d00089dc9d1
😎 Deploy Preview https://deploy-preview-3768--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 4385007

@AltefrohneGaelle AltefrohneGaelle merged commit eb5bac3 into 2.0 Sep 22, 2023
7 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the fix/SKFP-650-part-pheno-interpretation branch September 22, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants