Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data explo): SKFP-688 dash in empty cell #3773

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Sep 25, 2023

###[BUG] Display dash in empty cells

Description

SKFP-688

Cells fixed :

  • Data explo => participant => sex, vital status, Observed Phenotype (HPO)
  • Data explo => biospecimen => age

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

cell empty

After

Capture d’écran, le 2023-09-25 à 13 20 03 Capture d’écran, le 2023-09-25 à 13 18 17

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit af955f9
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/6511d2e24d208e0008c62bef
😎 Deploy Preview https://deploy-preview-3773--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit af955f9
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/6511d2e2f6934b0008360e43
😎 Deploy Preview https://deploy-preview-3773--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from af955f9

@AltefrohneGaelle AltefrohneGaelle merged commit 11ac979 into 2.0 Sep 25, 2023
7 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the fix/SKFP-688-empty-cell branch September 25, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants