Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variant): SKFP-850 fix NO_GENE case #3839

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

lflangis
Copy link
Collaborator

@lflangis lflangis commented Nov 6, 2023

BUG

Description

Salut! Dans le tableau du Variant Exploration, on ne veut pas afficher “NO GENE”. On va simplement retirer le “NO GENE” mais garder le restant de l’information qu’on a dans la cellule du Most Deleterious Consequence (ex. le point gris “intergenic”)

image

Dans la page Variant entity section Consequence:

Si dans le tableau Gene Consequence, la seule conséquence est “intergenic”, afficher le message “No data available” comme c’est fait les autres sections comme Pathogenicity.

Si dans le tableau Gene Consequence, il y a une conséquence “intergenic” et d’autres conséquence autre que “intergenic”, simplement pas afficher la conséquence “intergenic” mais toujours montrer les autres conséquences

J'ai aussi ajouté le cas pour le gene summary ou on affichait NO_GENE. Je retourne - a la place.

Acceptance Criterias

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

image
image

After

Screenshot from 2023-11-06 14-36-40
Screenshot from 2023-11-06 14-37-01
Screenshot from 2023-11-06 14-37-12
Screenshot from 2023-11-06 14-38-05

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit 8b53727
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65494a36136b470008ef2088
😎 Deploy Preview https://deploy-preview-3839--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit 8b53727
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65494a368e499a000814deb1
😎 Deploy Preview https://deploy-preview-3839--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from 7b5d42b

@lflangis lflangis merged commit 708dcc8 into 2.0 Nov 6, 2023
3 of 4 checks passed
@lflangis lflangis deleted the fix/SKFP-850/no-gene branch November 6, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants