Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tissue): SKFP-898 remove tissue type and text #3876

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Jan 11, 2024

[FEATURE] Remove tissue type and source text

SKFP-898

Description

I have only commented and not removed the code because we will add it again when data will be ok.

Acceptance Criterias

  • Participant entity page – Biospecimen table
  • Data Exploration – Facet & Biospecimen Table
  • Data Exploration – Biospecimen Download data report

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

After

Participant entity:

Capture d’écran, le 2024-01-11 à 15 08 34

Table and facets:

Capture d’écran, le 2024-01-11 à 15 06 34

Export TSV:

Capture d’écran, le 2024-01-11 à 15 07 11

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit d90cbc4
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/65a04b23fc215f0008a26908
😎 Deploy Preview https://deploy-preview-3876--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit d90cbc4
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/65a04b230c7c2800088e71ff
😎 Deploy Preview https://deploy-preview-3876--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from d90cbc4

@AltefrohneGaelle AltefrohneGaelle merged commit dd117cd into 2.0 Jan 11, 2024
8 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the feat/SKFP-898-remove-tissue-type branch January 11, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants