From 1742392aac5e13bb5f9db299bcabc52d5061ff72 Mon Sep 17 00:00:00 2001 From: GaelleA Date: Thu, 14 Nov 2024 11:46:51 -0500 Subject: [PATCH 1/3] fix(sentry): SKFP-1360 fix empty value in highlight search --- src/components/uiKit/search/GlobalSearch/utils.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/uiKit/search/GlobalSearch/utils.tsx b/src/components/uiKit/search/GlobalSearch/utils.tsx index 53f016ae3..614ebc671 100644 --- a/src/components/uiKit/search/GlobalSearch/utils.tsx +++ b/src/components/uiKit/search/GlobalSearch/utils.tsx @@ -1,7 +1,7 @@ import { isEmpty } from 'lodash'; export const highlightSearchMatch = (value: string, matchRegex: RegExp, search: string) => { - const result = !isEmpty(search) && value.search(matchRegex) >= 0; + const result = !isEmpty(search) && !isEmpty(value) && value.search(matchRegex) >= 0; return result ? ( Date: Thu, 14 Nov 2024 12:21:28 -0500 Subject: [PATCH 2/3] fix(sentry): SKFP-1360 error on undefined object --- src/store/passport/thunks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/passport/thunks.ts b/src/store/passport/thunks.ts index 0d87ed92a..a67c69c4c 100644 --- a/src/store/passport/thunks.ts +++ b/src/store/passport/thunks.ts @@ -98,7 +98,7 @@ export const connectCavaticaPassport = createAsyncThunk< return new Promise((resolve, reject) => { const interval = setInterval(async () => { - if (authWindow.closed) { + if (authWindow?.closed) { await thunkAPI.dispatch(fetchCavaticaAuthentificationStatus()); const { passport: { From 875120ea045c93c716b02d58d47f2fa90fa10185 Mon Sep 17 00:00:00 2001 From: GaelleA Date: Thu, 14 Nov 2024 12:27:31 -0500 Subject: [PATCH 3/3] fix(sentry): SKFP-1360 error on undefined object --- src/store/fences/thunks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/store/fences/thunks.ts b/src/store/fences/thunks.ts index c3590d129..a17c6c324 100644 --- a/src/store/fences/thunks.ts +++ b/src/store/fences/thunks.ts @@ -108,7 +108,7 @@ export const fenceOpenAuhentificationTab = createAsyncThunk< return new Promise((resolve, reject) => { const interval = setInterval(async () => { - if (authWindow.closed) { + if (authWindow?.closed) { const { data } = await FenceApi.isAuthenticated(fence); if (data?.authenticated) {