Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling No file error #13

Open
kidwm opened this issue Oct 17, 2014 · 2 comments
Open

Better handling No file error #13

kidwm opened this issue Oct 17, 2014 · 2 comments

Comments

@kidwm
Copy link
Owner

kidwm commented Oct 17, 2014

I've got this error output:

Warning: ENOENT, no such file or directory '/home/user/Projects/repo/root.html' Used --force, continuing.

In real case, When Apache does not find the file in #include, it would print the message in output file:
[an error occurred while processing this directive]

@67726e
Copy link
Collaborator

67726e commented Oct 17, 2014

I can and should provide better error logging for this type of situation. I will make sure it outputs something along the lines of "Could not include file foo.html from bar.html" when you have a missing file.

What I don't like, and maybe this boils down to a philosophical position, is the idea of outputting the error into the HTML and continuing on with just a log statement. When serving up dynamically parsed SSI on a webserver, that might make more sense so you don't scuttle an entire site because the footer is missing. In the case of this tool, it's a command-line utility and it should fail on that as it is a compile error in my eyes.

@kidwm
Copy link
Owner Author

kidwm commented Oct 20, 2014

Exactly, I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants