Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of discontinuity in HLS playlist #6

Closed
varsill opened this issue Nov 14, 2023 · 3 comments
Closed

Handling of discontinuity in HLS playlist #6

varsill opened this issue Nov 14, 2023 · 3 comments

Comments

@varsill
Copy link
Contributor

varsill commented Nov 14, 2023

Hello!
I wasn't sure where should I put that issue, and I thought it would be best to put it here - please correct me if I am wrong :D
In my pipeline, which uses HLS Source, I need to update timestamps in an appropriate way when the discontinuity (indicated by the ext-discontinuity flag in the HLS playlist) occurs.
Currently, such a discontinuity is not handled by the source, and there is no way to find out that it is happening.

To solve that problem I have created a couple of PRs that add support for reading ext-discontinuity flag from the HLS playlist as well as sending Membrane.Discontinuity.Event in case discontinuity occurs. More details are described in the PRs themselves:

@dmorn
Copy link
Member

dmorn commented Jan 17, 2024

Hi @varsill, are we complete?

@dmorn
Copy link
Member

dmorn commented Mar 7, 2024

@varsill ping! ;)

@varsill
Copy link
Contributor Author

varsill commented Mar 12, 2024

Hi @dmorn, sorry for such a late response! Indeed, we are complete, so I will close the issue.

@varsill varsill closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants