Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoints to delete customer/project/activity #5181

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

kevinpapst
Copy link
Member

Description

API endpoints to delete customer/project/activity

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.48%. Comparing base (f13b81e) to head (d2b4ea3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5181   +/-   ##
=========================================
  Coverage     87.48%   87.48%           
- Complexity     9218     9224    +6     
=========================================
  Files           809      809           
  Lines         30488    30509   +21     
=========================================
+ Hits          26671    26691   +20     
- Misses         3817     3818    +1     
Files with missing lines Coverage Δ
src/API/ActivityController.php 97.45% <100.00%> (+0.08%) ⬆️
src/API/CustomerController.php 99.06% <100.00%> (+0.03%) ⬆️
src/API/ProjectController.php 94.85% <100.00%> (+0.15%) ⬆️
src/Activity/ActivityService.php 94.44% <100.00%> (+0.32%) ⬆️
src/Customer/CustomerService.php 88.88% <100.00%> (+0.55%) ⬆️
src/Project/ProjectService.php 94.82% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

@kevinpapst kevinpapst merged commit e030ff0 into main Nov 27, 2024
7 checks passed
@kevinpapst kevinpapst deleted the api-delete branch November 27, 2024 14:25
@robertlemke
Copy link

Fantastic! Thank you for implementing that feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants