Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off the label that has not been connected yet will Crash, this problem is back with 2.2.0 pre1 #206

Open
xzhuiz opened this issue Sep 27, 2021 · 6 comments

Comments

@xzhuiz
Copy link

xzhuiz commented Sep 27, 2021

Turn off the label that has not been connected yet will Crash
this problem is back with 2.2.0 pre1

@kingToolbox
Copy link
Owner

Thank you. I will investigate this issue. This version has modified a lot of code, so the version quality will take a while to stabilize.

@kingToolbox
Copy link
Owner

Sorry, I failed to reproduce this issue. Would you like to describe the steps in detail or help me reproduce it once and submit the generated crash report here? The crash report is just in the current working directory after the crash, such as 8f9a5ae5-4ea2-170e-55e9b70e-05c9ab40.dmp, you can post it as an attachment in the issue. I will analyze it and fix the problem. Thank you.

The crash report is a standard minidump file and does not contain any private information. You can read this comment to learn more.

@xzhuiz
Copy link
Author

xzhuiz commented Oct 8, 2021

Find a relatively slow server. For example, DNS check is turned on
Open a tab to connect it
When it is not connected yet, close the tab
15d5a72d-a1a8-4766-a666-ca5c4bb4e63f.zip

@kingToolbox
Copy link
Owner

Hello, I have tried to fix this issue according to the minidump file, but because I have no environment to reproduce this fault, I am not sure whether I have successfully fixed it. Please download WindTerm_2.2.0_Prerelease_2 and check it. If it is not fixed, I will continue to try to fix it. Thank you very much.

@xzhuiz
Copy link
Author

xzhuiz commented Oct 15, 2021

Yes, pre2 fixed it, although it would get stuck for a few seconds
2.1.0 earlier versions also had this problem, which was later fixed. And it won't be stuck for a few seconds
#25

@kingToolbox
Copy link
Owner

I am happy to hear the good news that it has been fixed. I will investigate why it is stuck, but if I cannot reproduce it on my machine, it may take some time.

In addition, although this problem has been solved before, the past solutions have been invalidated due to the complete refactoring and rewriting of most modules in version 2.2.0. But it doesn't matter, the problem will eventually be fixed. I will update any progress here, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants