Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] QD base code additions #22

Merged
merged 5 commits into from
May 6, 2024
Merged

[FEAT] QD base code additions #22

merged 5 commits into from
May 6, 2024

Conversation

kevinl424
Copy link
Collaborator

  • query decomposition initial code
  • only notebooks included

@kevinl424 kevinl424 requested a review from seyeong-han May 5, 2024 16:42
@kevinl424 kevinl424 linked an issue May 5, 2024 that may be closed by this pull request
Add query decomposition base code #16
Closed
@kevinl424 kevinl424 changed the title add: QD base code additions [FEAT] QD base code additions May 5, 2024
@kevinl424 kevinl424 added the enhancement New feature or request label May 5, 2024
seyeong-han
seyeong-han previously approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@seyeong-han seyeong-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all this previous work!
Could you provide explanations for each file?

@kevinl424
Copy link
Collaborator Author

Thanks for adding all this previous work! Could you provide explanations for each file?

File Breakdown

  • langchain_ms.ipynb - using LangChain to breakdown subqueries
  • MS_finetuning.ipynb - fine-tuning the query decomposition
  • rest - multi step query decomp examples

@kevinl424 kevinl424 requested a review from seyeong-han May 6, 2024 21:44
seyeong-han
seyeong-han previously approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@seyeong-han seyeong-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your file descriptions.

kingjulio8238
kingjulio8238 approved these changes May 6, 2024
View reviewed changes
Copy link
Owner

@kingjulio8238 kingjulio8238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hope to see QD being used once multiprocessing has been integrated!

@kevinl424 kevinl424 requested a review from seyeong-han May 6, 2024 21:57
@seyeong-han seyeong-han merged commit b07bed9 into main May 6, 2024
@kevinl424 kevinl424 deleted the add-qd branch May 8, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjulio8238 kingjulio8238 kingjulio8238 approved these changes

@seyeong-han seyeong-han seyeong-han approved these changes

@arnavchopra1864 arnavchopra1864 Awaiting requested review from arnavchopra1864

@aishwarya-balaji aishwarya-balaji Awaiting requested review from aishwarya-balaji

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query decomposition base code
4 participants
@kevinl424 @seyeong-han @kingjulio8238 @aSiri13